[PATCH] D154306: [InstCombine] Generalise ((x1 ^ y1) | (x2 ^ y2)) == 0 transform

Maksim Kita via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 06:54:40 PDT 2023


kitaisreal marked an inline comment as done.
kitaisreal added a comment.

I do not have commit access. Can you please land this one for me Maksim Kita <kitaetoya at gmail.com> ?



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:1980
+    if (!match(CurrentValue,
+               m_Or(m_Value(OrOperatorLhs), m_Value(OrOperatorRhs)))) {
+      return nullptr;
----------------
nikic wrote:
> nit: Omit braces for single-line if.
I plan to continue this optimization for 'sub' in my next patch, so I will fix nitpick in next patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154306/new/

https://reviews.llvm.org/D154306



More information about the llvm-commits mailing list