[PATCH] D154638: Emit a .debug_addr section with dsymutil

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 06:28:53 PDT 2023


rastogishubham added inline comments.


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-addr_base.test:49
+RUN: rm -rf %t.dir && mkdir -p %t.dir
+RUN: dsymutil -y %p/dummy-debug-map-amr64.map -oso-prepend-path=%p/../Inputs/DWARF5-addr_base -o %t.dir/dwarf5-addr_base.dSYM
+RUN: llvm-dwarfdump %t.dir/dwarf5-addr_base.dSYM -a --verbose | FileCheck %s
----------------
avl wrote:
> add a check for "-u" case, please.
I am not sure what should happen in a -u case

Should the DW_AT_addr_base be patched in a -u case? It doesn't get patched now


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154638/new/

https://reviews.llvm.org/D154638



More information about the llvm-commits mailing list