[PATCH] D155193: [LangRef] vscale_range implies the vscale is power-of-two

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

I've offered some alternate phrasing to consider but am happy to accept the patch on principle.  Please give others a chance to comment on your final choice of phrasing before landing the patch.



================
Comment at: llvm/docs/LangRef.rst:2335-2339
     This attribute indicates the minimum and maximum vscale value for the given
     function. The min must be greater than 0. A maximum value of 0 means
     unbounded. If the optional max value is omitted then max is set to the
     value of min. If the attribute is not present, no assumptions are made
+    about the range of vscale. The values of min and max are power of two
----------------
I'd prefer a more unified description.  What about:
```
This function attribute indicates `vscale` is a power-of-two within a specified range. `min` must be a power-of-two that is greater than 0. When specified, `max` must be a power-of-two greater-than-or-equal to `min` or 0 to signify an unbounded maximum. The syntax `vscale_range(<val>)` can be used to set both `min` and `max` to the same value. Functions that don't include this attribute make no assumptions about the value of `vscale`.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155193/new/

https://reviews.llvm.org/D155193