[PATCH] D153151: [EarlyCSE] Do not CSE convergent calls with memory effects

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/EarlyCSE.cpp:545
+  CallInst *LHSI = cast<CallInst>(LHS.Inst);
+  CallInst *RHSI = cast<CallInst>(RHS.Inst);
+
----------------
arsenm wrote:
> Is this supposed to implicitly assume invokes and callbr can't reach here?
Yes. This is checked in `CallValue::canHandle`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153151/new/

https://reviews.llvm.org/D153151