[PATCH] D155268: [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk
Tobias Hieta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 14 02:22:37 PDT 2023
thieta retitled this revision from "[lld][COFF] Find libraries with relative paths" to "[lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk".
thieta updated this revision to Diff 540332.
thieta added a comment.
Add example to release notes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155268/new/
https://reviews.llvm.org/D155268
Files:
lld/COFF/Driver.cpp
lld/docs/ReleaseNotes.rst
lld/test/COFF/relative_search_paths.test
Index: lld/test/COFF/relative_search_paths.test
===================================================================
--- /dev/null
+++ lld/test/COFF/relative_search_paths.test
@@ -0,0 +1,4 @@
+We should be able to find libraries with relative search paths.
+# RUN: mkdir -p %t.dir/relative/path
+# RUN: cp %p/Inputs/std64.lib %t.dir/relative/path
+# RUN: lld-link %p/Inputs/hello64.obj /libpath:%t.dir relative/path/std64.lib /entry:main
Index: lld/docs/ReleaseNotes.rst
===================================================================
--- lld/docs/ReleaseNotes.rst
+++ lld/docs/ReleaseNotes.rst
@@ -37,6 +37,10 @@
COFF Improvements
-----------------
+* lld-link can now find libraries with relative search paths.
+ I.e. ``lld-link relative/path/my.lib`` where before we would have to do
+ ``lld-link /libpath:relative/path my.lib``
+
MinGW Improvements
------------------
Index: lld/COFF/Driver.cpp
===================================================================
--- lld/COFF/Driver.cpp
+++ lld/COFF/Driver.cpp
@@ -483,8 +483,7 @@
return filename;
};
- bool hasPathSep = (filename.find_first_of("/\\") != StringRef::npos);
- if (hasPathSep)
+ if (sys::path::is_absolute(filename))
return getFilename(filename);
bool hasExt = filename.contains('.');
for (StringRef dir : searchPaths) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155268.540332.patch
Type: text/x-patch
Size: 1326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230714/4175fcef/attachment.bin>
More information about the llvm-commits
mailing list