[PATCH] D147740: [llvm-profdata] Refactoring Sample Profile Reader to increase FDO build speed using MD5 as key to Sample Profile map

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In D147740#4499375 <https://reviews.llvm.org/D147740#4499375>, @huangjd wrote:

> Always use little endian write on Line 586 in SampleProfileReader.cpp, this should make it consistent on different systems

With the last revision, the assertion failures are gone.  However, two tailures do remain:

  +  LLVM :: Transforms/SampleProfile/inline-mergeprof.ll
  
  Command Output (stderr):
  --
  /vol/llvm/src/llvm-project/local/llvm/test/Transforms/SampleProfile/profile-format.ll:27:10: error: CHECK: expected string not found in input
  ; CHECK: br i1 %cmp, label %while.body, label %while.end{{.*}} !prof ![[IDX1:[0-9]*]]
           ^
  <stdin>:1:1: note: scanning from here
  ; ModuleID = '<stdin>'
  ^
  <stdin>:32:2: note: possible intended match here
   br i1 %cmp, label %while.body, label %while.end, !dbg !42
   ^
  
  +  LLVM :: Transforms/SampleProfile/profile-format.ll
  
  Command Output (stderr):
  --
  /vol/llvm/src/llvm-project/local/llvm/test/Transforms/SampleProfile/profile-format.ll:27:10: error: CHECK: expected string not found in input
  ; CHECK: br i1 %cmp, label %while.body, label %while.end{{.*}} !prof ![[IDX1:[0-9]*]]
           ^
  <stdin>:1:1: note: scanning from here
  ; ModuleID = '<stdin>'
  ^
  <stdin>:32:2: note: possible intended match here
   br i1 %cmp, label %while.body, label %while.end, !dbg !42
   ^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147740/new/

https://reviews.llvm.org/D147740