[PATCH] D155254: Fixed an issue where llvm-gsymutil would crash when parsing bad inline ranges.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 17:48:23 PDT 2023


clayborg created this revision.
clayborg added reviewers: yinghuitan, ayermolo, aprantl.
Herald added a subscriber: hiraditya.
Herald added a project: All.
clayborg requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

If a function contains inline function ranges whose address ranges are not contained in the parent scope, then emit an error message and omit them from the final GSYM. Prior to this we would only test if an inline function's address range was within the concrete function's ranges. If we ran into a case where the inline range was within the function's ranges, but not within one of the parent inline function's ranges, then we would fail to produce a GSYM file and exit with an error.

The current code will emit full details on invalid inline ranges as they are being parsed and will omit any bad ranges from the final GSYM file.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155254

Files:
  llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
  llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
  llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155254.540242.patch
Type: text/x-patch
Size: 16119 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230714/be3c3aa1/attachment.bin>


More information about the llvm-commits mailing list