[PATCH] D155142: Add PBNDKB instruction.

[Freddy, Ye via Phabricator via llvm-commits]

FreddyYe added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrSystem.td:433
 
+let Uses = [RAX, RBX, RCX], Predicates = [In64BitMode] in
+def PBNDKB : I<0x01, MRM_C7, (outs), (ins), "pbndkb", []>, PS;
----------------
pengfei wrote:
> It defs RAX instead of use.
Good catch!


================
Comment at: llvm/lib/Target/X86/X86InstrSystem.td:434
+let Uses = [RAX, RBX, RCX], Predicates = [In64BitMode] in
+def PBNDKB : I<0x01, MRM_C7, (outs), (ins), "pbndkb", []>, PS;
 let Uses = [RSI, RDI, RCX], Predicates = [In64BitMode] in {
----------------
skan wrote:
> Doesn't this instruction affect EFLAGS?
Good catch. Added `def EFLAGS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155142/new/

https://reviews.llvm.org/D155142