[PATCH] D154791: [InstCombine] Transform bitwise (A >> C - 1, zext(icmp)) -> zext (bitwise(A < 0, icmp)) fold.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1753
+    Worklist.popDeferred()->eraseFromParent();
+    Worklist.popDeferred()->eraseFromParent();
+    return nullptr;
----------------
@nikic, is this right?


================
Comment at: llvm/test/Transforms/InstCombine/and-or-icmps.ll:2887
   %C = lshr i32 %x, 31
   %D = and i32 %C, %B
   call void @use32(i32 %B)
----------------
Since you're now supporting xor, you need to add some tests for it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154791/new/

https://reviews.llvm.org/D154791