[PATCH] D155240: [amdgpu][lds] Use amdgpu-lds-size instead of llvm.donothing

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:904
 
   for (GlobalVariable &GV : Mod->globals()) {
     if (GV.getAddressSpace() != AMDGPUAS::LOCAL_ADDRESS)
----------------
Most of this iteration and search for LDS could be dropped for kernels that are transformed by LowerModuleLDSPass if it added an attribute for dynamic lds alignment, along with amdgpu-lds-size.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155240/new/

https://reviews.llvm.org/D155240