[PATCH] D153967: [lit] Remove the --no-indirectly-run-check option

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a reviewer: thopre.
jdenny added inline comments.


================
Comment at: llvm/docs/CommandGuide/lit.rst:462
  standalone. Test discovery is disabled for that directory and
  *--no-indirectly-run-check* is in effect. *lit.suffixes* and *lit.excludes*
  must be empty when this variable is true.
----------------
Needs to be updated.


================
Comment at: llvm/utils/lit/lit/discovery.py:170-171
+        # tests.
+        tests = [Test.Test(ts, path_in_suite, lc)] if lc.test_format is None or lc.standalone_tests else \
                 lc.test_format.getTestsForPath(ts, path_in_suite, litConfig, lc)
 
----------------
If I understand correctly, if a directory is in standalone mode because tests are always run individually, it is not possible to use a test format that overrides getTestsForPaths in order to generate multiple tests from each of those individual tests.  Is that correct?  I'm not saying that's problematic.  I just want to be sure I understand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153967/new/

https://reviews.llvm.org/D153967