[PATCH] D155087: [CodeGen] Fix assertion failure caused by inline assembly

Bryan Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 14:05:34 PDT 2023


bryanpkc added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:941
+      setPhysReg(MI, MO, *AllocationOrder.begin());
+      return true;
+    }
----------------
Why doesn't this return the result of `setPhysReg`?

You should also add a comment to explain that since there was an error finding a suitable register for `LRI`, we just pick a register at random and bail out of the function immediately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155087/new/

https://reviews.llvm.org/D155087



More information about the llvm-commits mailing list