[PATCH] D155232: [llvm] Remove uses of Type::getPointerTo() (NFC)

Youngsuk Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 14:03:44 PDT 2023


JOE1994 added inline comments.


================
Comment at: llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp:705
+      return Builder.CreatePointerCast(remap(Tmp0),
+                                       PointerType::getUnqual(ValTy), "cst");
     }
----------------
Given that this line is guarded by `if (!PtrTy->isOpaque()`,
I wasn't sure whether using `PointerType::getUnqual(LLVMContext&)` here is acceptable.

For now, I chose to play safe and just used `PointerType::getUnqual(Type *)` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155232/new/

https://reviews.llvm.org/D155232



More information about the llvm-commits mailing list