[PATCH] D151796: [SCEV] Skip min/max expressions when normalizing/denormalizing SCEV expressions

Thu Jul 13 13:06:28 PDT 2023

nikic added a comment.

In D151796#4498796 <https://reviews.llvm.org/D151796#4498796>, @apilipenko wrote:

> We continue relying on normalization/denormalization round trip producing the original expression (e.g. D153004 <https://reviews.llvm.org/D153004>). Even if this patch doesn't fix all the cases where this property doesn't hold true, it is an improvement.
>
> @nikic, @fhahn, are there any objections to moving forward with this change as a first step?

https://reviews.llvm.org/rG7f5b15ad150e59815fbd4adc3202c8720718896e made normalizeForPostIncUse() return nullptr if it normalization/denormalization doesn't round-trip -- shouldn't that fully address this issue? Do you still see normalization related miscompiles in LSR after that change?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151796/new/

https://reviews.llvm.org/D151796