[PATCH] D155190: [amdgpu][lds] Remove recalculation of LDS frame from backend

Thu Jul 13 12:54:05 PDT 2023

arsenm added inline comments.

================
Comment at: llvm/docs/AMDGPUUsage.rst:1095
+                                             address zero. Variables are allocated within this frame using absolute
+                                             symbol metadata, primarily by the AMDGPULowerModuleLDS pass.
+
----------------
Note frontends shouldn't be setting it?

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:1109

+  // This attribute is no lnger used by the backend. TODO: Delete it in favour
+  // of pass-local state and update the tests to remove the string.
----------------
Typo lnger

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.cpp:87
+      if (ObjectStart != alignTo(ObjectStart, Alignment)) {
+        report_fatal_error("Absolute address LDS variable inconsistent with "
+                           "variable alignment");
----------------
Probably should go through DiagnosticInfo. I don't know why we don't have sensible predefined types for this sort of thing.   DK_Lowering looks promising but is buried in one specific user

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155190/new/

https://reviews.llvm.org/D155190