[PATCH] D154737: [BOLT] Add stale-related logging

[Sergey Pupyrev via Phabricator via llvm-commits]

spupyrev added inline comments.


================
Comment at: bolt/include/bolt/Core/BinaryFunction.h:391-400
+  /// Inference stats:
+  ///   the total number of basic blocks in the profile
+  uint32_t NumStaleBlocks{0};
+  ///   the number matched basic blocks
+  uint32_t NumMatchedBlocks{0};
+  ///   the total count of samples in the profile
+  uint64_t StaleSampleCount{0};
----------------
maksfb wrote:
> Let's move the stats out of the `BinaryFunction`.  Once the input function list is populated, function addresses are fixed. You can use a map, e.g., to attach stats to `BinaryFunction *`. I'm also not sure you need per-function stats or having aggregated is enough.
Yes that's what I was thinking on doing. Is there a good example of storing stats or some other info across different passes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154737/new/

https://reviews.llvm.org/D154737