[PATCH] D155216: [RISCV] Add initial SDNode patterns for unary zvbb instructions

[Luke Lau via Phabricator via llvm-commits]

luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td:185
+
+multiclass VPseudoUnary_V {
+  foreach m = MxList in {
----------------
4vtomat wrote:
> Thanks, overall it's great!
> One minor thing, if it can follow the naming convention such as [[ https://github.com/llvm/llvm-project/blob/8bb9414f1474d6a8caed2e7be5f1d3d999c8bae1/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td#L2066C12-L2066C29 | this ]], that would be more consistent~
> I guess maybe something like: `VPseudoUnaryV_V`.
> 
Sounds good, will do!
Btw, I was wondering since this multiclass isn't specific to zvk, should it be moved into RISCVInstrInfoVPseudos.td?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155216/new/

https://reviews.llvm.org/D155216