[PATCH] D151039: [Docs][llvm-exegesis] Add documentation for memory

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-exegesis.rst:79
+  process. The value name refers to a previously defined memory definition and
+  the address is a decimal number that specifies the address the memory
+  definition should start at. Note that a single memory definition can be
----------------
ondrasej wrote:
> Would it be possible to parse both decimal and hex? E.g. parse "123" as decimal, and "0x123" as hex.
> 
> Similar for the size of the memory (on the other side, the value stored in the memory might be easiest when kept only in hex).
Yes, this is possible, just not something I currently have implemented (but probably something I should write up a patch for at some point). Since this isn't supported currently, I'm thinking we leave the documentation as is, documenting the functionality currently, and then add in enhanced parsing along with documentation changes in a future patch. Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151039/new/

https://reviews.llvm.org/D151039