[PATCH] D155194: [SystemZ][NFC] Use named sub-operands in MC

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

This looks really nice, thanks for that improvement!   A couple of trivial nits inline, otherwise LGTM.



================
Comment at: llvm/lib/Target/SystemZ/SystemZInstrFormats.td:612
 
+class InstRSEa<bits<16> op, dag outs, dag ins, string asmstr, list<dag> pattern>
+  : InstSystemZ<6, outs, ins, asmstr, pattern> {
----------------
Minor nit: can you move this next to the `InstRSY` definitions?


================
Comment at: llvm/lib/Target/SystemZ/SystemZInstrFormats.td:2852
   let mayStore = 1 in {
-    def Align : InstVRSa<opcode, (outs), (ins VR128:$V1, VR128:$V3,
-                                              bdaddr12only:$BD2, imm32zx4:$M4),
+    def Align : InstVRSa<opcode, (outs),(ins VR128:$V1, VR128:$V3,
+                                             (bdaddr12only $B2, $D2):$BD2,
----------------
Looks like you accidentally removed the space after comma here.


================
Comment at: llvm/lib/Target/SystemZ/SystemZInstrFormats.td:5163
   : Pseudo<(outs cls:$R1),
-           (ins cls:$R2, mode:$XBD2, cond4:$valid, cond4:$M3), []> {
+           (ins cls:$R2, (mode $B2, $D2):$BD2, cond4:$valid, cond4:$M3), []> {
     let OpKey = !subst("loc", "sel", mnemonic)#"r"#cls;
----------------
I see, the original `$XBD` was actually a bug.  Good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155194/new/

https://reviews.llvm.org/D155194