[PATCH] D154921: Support -frecord-command-line for XCOFF integrated assembler path

Jake Egan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 09:11:50 PDT 2023


Jake-Egan added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:258
+
+  CInfoSymSectionEntry(StringRef N, int32_t Flags) : SectionEntry(N, Flags){};
+  virtual ~CInfoSymSectionEntry() = default;
----------------
scott.linder wrote:
> formatting
Do you mean that `CInfoSymSectionEntry(StringRef N, int32_t Flags) : SectionEntry(N, Flags){};` should be split into two lines? It seems git-clang-format wants it on one line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154921/new/

https://reviews.llvm.org/D154921



More information about the llvm-commits mailing list