[PATCH] D155155: [RISCV] emit .option directive when attribute different

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 07:12:09 PDT 2023


asb added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/riscv-func-attr-target.ll:2
+; RUN: llc -mtriple=riscv64 -mattr=+a,+d,+f,+m -verify-machineinstrs < %s | FileCheck %s
+
+; CHECK: .option push
----------------
I think you want a test function that _doesn't_ have any additional target-features, and you can then verify that .option arch isn't blindly emitted for every function (rather than just those where it differs to the module).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155155/new/

https://reviews.llvm.org/D155155



More information about the llvm-commits mailing list