[PATCH] D152706: [AMDGPU] Use SSAUpdater in PromoteAlloca

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:391
+      // (e.g. load <8 x i8> as ptr), we first need to cast to int.
+      if (Inst->getType()->isPointerTy()) {
+        CurVal =
----------------
Pierre-vh wrote:
> arsenm wrote:
> > Doesn't consider vector of pointers
> What case do you have in mind? This code path is just for loading the full vector. I initially had a test for a `<1 x ptr>` vector but we don't vectorize under 2 elements so it never worked.
> 
store <2 x ptr> 
load <4 x ptr addrspace(3)>

things like that



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152706/new/

https://reviews.llvm.org/D152706