[PATCH] D155071: [RISCV] Fold vmerge into its ops with smaller VL if known
Luke Lau via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 13 06:04:39 PDT 2023
luke added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:3319
+ return LHS;
+ if (auto *CLHS = dyn_cast<ConstantSDNode>(LHS),
+ *CRHS = dyn_cast<ConstantSDNode>(RHS);
----------------
fakepaper56 wrote:
> Is the below code more concise?
> ```
> if (auto *CLHS = dyn_cast<ConstantSDNode>(LHS))
> if (auto *CRHS = dyn_cast<ConstantSDNode>(RHS))
> ```
Yeah that's much more readable, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155071/new/
https://reviews.llvm.org/D155071
More information about the llvm-commits
mailing list