[PATCH] D154824: [AMDGPU] Check for denormal flushing when selecting V_FMA/MAD_MIX*

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 02:42:16 PDT 2023


foad added a comment.

In D154824#4496498 <https://reviews.llvm.org/D154824#4496498>, @matejam wrote:

> Since it doesn't affect any tests, should I add this line in D153544 <https://reviews.llvm.org/D153544>?

It would be better to add some tests here (or maybe just add some RUN lines to existing tests) that //do// show the effect.



================
Comment at: llvm/lib/Target/AMDGPU/VOP3PInstructions.td:251
 defm : MadFmaMixPats<fmad, V_MAD_MIX_F32, V_MAD_MIXLO_F16, V_MAD_MIXHI_F16>;
 } // End SubtargetPredicate = HasMadMixInsts
 
----------------
Update this comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154824/new/

https://reviews.llvm.org/D154824



More information about the llvm-commits mailing list