[PATCH] D154953: [InstCombine] Remove the remainder loop if we know the mask is always true

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/AArch64/rem-mul-shl.ll:39
+
+define i64 @urem_shl_vscale_out_of_range() #0 {
+; CHECK-LABEL: @urem_shl_vscale_out_of_range(
----------------
david-arm wrote:
> Based on your ValueTracking change I think you also need a negative test when vscale_range is set to something like (1,15)
Based on my suggestion such a test cannot be written because it will be bad IR that will generate an error once the LangRef change is made, which needs to happen before we can have patches that rely on the new behaviour.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154953/new/

https://reviews.llvm.org/D154953