[PATCH] D152714: [AArch64][Optimization]Emit FCCMP for AND of two float compares

Thu Jul 13 02:27:36 PDT 2023

samtebbs added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/select_fmf.ll:15-17
+; CHECK-NEXT:    cset w8, gt
+; CHECK-NEXT:    cmp w8, #0
+; CHECK-NEXT:    fcsel s2, s1, s0, ne
----------------
This change doesn't look beneficial because it adds extra instructions that aren't really needed. I think we'll need to find a way of restricting the code you've written to not transform this example. You can try looking at the debug output with the `-print-after-all` option added to `llc` to see what is different for this test case and the one you added. While testing you can copy this test file and remove everything but the two functions we're interested in to reduce the debug output when you run llc on it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152714/new/

https://reviews.llvm.org/D152714