[PATCH] D155132: [amdgpu][lds] Raise an explicit unimplemented error on absolute address LDS variables

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez accepted this revision.
jmmartinez added a comment.
This revision is now accepted and ready to land.

Looks good to me. If you think it's relevant to privde a better diagnostic with the souce location I'd welcome that change.

I was thinking about using `LLVMContext::diagnose` + `DiagnosticInfoUnsupported` but it seems there is no alternative for GlobalVariables (only for Functions) and adding support for it is a whole other patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155132/new/

https://reviews.llvm.org/D155132