[PATCH] D151283: [llvm-cov] Support a Hierarchical Structure for HTML Coverage Report Generating

Yuhao Gu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 22:21:00 PDT 2023


AtomicGu marked an inline comment as done.
AtomicGu added inline comments.


================
Comment at: llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp:432
+
+void CoveragePrinterHTML::emitBeforeTable(raw_ostream &OSRef,
+                                          const std::string &Title) {
----------------
phosek wrote:
> This is a just a suggestion, but I think that `emitPrelude` might be a better name.
This name has been used by another function in the anonymous namespace in `SourceCoverageViewHTML.cpp`. So I chose a different name to avoid confusion, although no conflict would be caused if I used `emitPrelude` since the arguments are different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151283/new/

https://reviews.llvm.org/D151283



More information about the llvm-commits mailing list