[PATCH] D155023: Don't assert on a non-pointer value being used for a "p" inline asm constraint.

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 19:21:43 PDT 2023


pengfei added a comment.

My concern is removing assert don't solve the real problem. I think there are two problems here:

1. Compiler shouldn't assert for invalid semantics.  That's true. We could solve it by detecting such invalid semantics during sema checking.
2. Application relies on invalid semantics. This is my main concern. Besides, I took a look at GCC and find it report error for it https://godbolt.org/z/zPWhsY5aj


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155023/new/

https://reviews.llvm.org/D155023



More information about the llvm-commits mailing list