[PATCH] D155143: [DX] Fix PSV resource serialization

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 18:57:04 PDT 2023


beanz created this revision.
beanz added reviewers: pete, bogner, python3kgae, pow2clk, tex3d.
Herald added a subscriber: hiraditya.
Herald added a project: All.
beanz requested review of this revision.
Herald added a project: LLVM.

When writing this initially I missed including the resource stride.
This change adds the resources stride to the serialized value.

I've also extended the testing and error reporting around parsing PSV
information. This adds tests to verify that the reader produces
meaningful error messages for malformed DXContainer files, and a test
that verifies the resource stride is respected in the reader even if
the stride isn't an expected or known value (as would happen if the
format changes in the future).

This is part of #59479.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155143

Files:
  llvm/include/llvm/Object/DXContainer.h
  llvm/include/llvm/ObjectYAML/DXContainerYAML.h
  llvm/lib/MC/DXContainerPSVInfo.cpp
  llvm/lib/Object/DXContainer.cpp
  llvm/lib/ObjectYAML/DXContainerYAML.cpp
  llvm/test/ObjectYAML/DXContainer/PSVv0-amplification.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv0-compute.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv0-domain.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv0-geometry.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv0-hull.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv0-mesh.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv0-pixel.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv0-vertex.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv1-amplification.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv1-compute.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv1-domain.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv1-geometry.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv1-hull.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv1-mesh.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv1-pixel.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv1-vertex.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv2-amplification.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv2-compute.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv2-domain.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv2-geometry.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv2-hull.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv2-mesh.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv2-pixel.yaml
  llvm/test/ObjectYAML/DXContainer/PSVv2-vertex.yaml
  llvm/tools/obj2yaml/dxcontainer2yaml.cpp
  llvm/unittests/Object/DXContainerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155143.539814.patch
Type: text/x-patch
Size: 34260 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230713/1a0d01f9/attachment-0001.bin>


More information about the llvm-commits mailing list