[PATCH] D154979: [RISCV] Add test for vmerge combine that should be prevented

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/comment.



================
Comment at: llvm/test/CodeGen/RISCV/rvv/rvv-peephole-vmerge-vops.ll:382
+
+; FIXME: This shouldn't be folded because the mask has been changed here
+define <vscale x 2 x float> @vpmerge_constrained_fadd_vlmax(<vscale x 2 x float> %passthru, <vscale x 2 x float> %x, <vscale x 2 x float> %y, <vscale x 2 x i1> %m) strictfp {
----------------
Add a bit to the comment to emphasize that suppressing exceptions is also disallowed by "fpexcept.strict".  Removing exceptions is fine under both ignore and maytrap, so it's good to emphasize that bit of the semantic.   




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154979/new/

https://reviews.llvm.org/D154979