[PATCH] D155122: Revert "[ARM] Restructure MOVi32imm expansion to not do pointless instructions"

Nathan Chancellor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 16:01:13 PDT 2023


nathanchance added a comment.

I think 210f61cbddeddac47b347db072d674ee142520f6 <https://reviews.llvm.org/rG210f61cbddeddac47b347db072d674ee142520f6> needs to be reverted as well, otherwise `llvm/test/CodeGen/ARM/copy-by-struct-i32.ll` fails for me:

  llvm/test/CodeGen/ARM/copy-by-struct-i32.ll:43:18: error: ASSEMBLY-NEXT: is not on the line after the previous match
  ; ASSEMBLY-NEXT: .LBB0_1: @ %entry
                   ^
  <stdin>:55:1: note: 'next' match was here
  .LBB0_1: @ %entry
  ^
  <stdin>:53:14: note: previous match ended here
   movw r4, #72
               ^
  <stdin>:54:1: note: non-matching line after previous match is here
   movt r4, #0
  ^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155122/new/

https://reviews.llvm.org/D155122



More information about the llvm-commits mailing list