[PATCH] D155125: [amdgpu][lds] Introduce LDS frame size function attribute
Jon Chesterfield via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 12 15:44:00 PDT 2023
JonChesterfield added a comment.
In D155125#4495323 <https://reviews.llvm.org/D155125#4495323>, @arsenm wrote:
> Should document what it means in AMDGPUUsage
Maybe? The attributes section says "...backend supports the following LLVM IR attributes" which sounds user facing. While it's possible to set the attributes&metadata by hand and disable the lowering pass, doing so would take a fair amount of reverse engineering. I'm happier leaving this undocumented.
================
Comment at: llvm/test/CodeGen/AMDGPU/lower-module-lds.ll:67
+; CHECK: attributes #0 = { "amdgpu-lds-size"="12" }
+; CHECK: attributes #1 = { "amdgpu-elide-module-lds" }
----------------
arsenm wrote:
> is this one going away?
Yep.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155125/new/
https://reviews.llvm.org/D155125
More information about the llvm-commits
mailing list