[PATCH] D154306: [InstCombine] Generalise ((x1 ^ y1) | (x2 ^ y2)) == 0 transform

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp-or.ll:415
+  ret i1 %cmp
+}
----------------
kitaisreal wrote:
> goldstein.w.n wrote:
> > goldstein.w.n wrote:
> > > Can you 1) split the tests to a seperate patch (so we can see the diff this patch generates).
> > > 2) Can you add a few negative tests (maybe where cmp is not against 0, one of the xors has multiuse, where its or->or (invalid), etc...).
> > This is still outstanding.
> I moved tests into separate patch https://reviews.llvm.org/D154384. Should we merge it first so we can see the difference after this patch is applied ?
Do the following.

Rebase this patch ontop of the test change (so instead of this patch adding a bunch of tests, we should see diffs generated).

Then use the "Edit Related Revisions" option on phabricator and set this commit as the child of the test commit.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154306/new/

https://reviews.llvm.org/D154306