[llvm] 95d833d - [nfc] rename `AM` to `MAM` in PGOInstrumentation
Mircea Trofin via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 12 14:46:14 PDT 2023
Author: Mircea Trofin
Date: 2023-07-12T14:45:58-07:00
New Revision: 95d833d7c35ed46b1883b30de027cbcf2a667bff
URL: https://github.com/llvm/llvm-project/commit/95d833d7c35ed46b1883b30de027cbcf2a667bff
DIFF: https://github.com/llvm/llvm-project/commit/95d833d7c35ed46b1883b30de027cbcf2a667bff.diff
LOG: [nfc] rename `AM` to `MAM` in PGOInstrumentation
Consistency with how we tend to name `ModuleAnalysisManager` parameters.
Added:
Modified:
llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h
llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h b/llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h
index 952bc2f8edbe34..c77d3214ed010d 100644
--- a/llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h
+++ b/llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h
@@ -42,7 +42,7 @@ class PGOInstrumentationGenCreateVar
public:
PGOInstrumentationGenCreateVar(std::string CSInstrName = "")
: CSInstrName(CSInstrName) {}
- PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+ PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
private:
std::string CSInstrName;
@@ -52,7 +52,7 @@ class PGOInstrumentationGenCreateVar
class PGOInstrumentationGen : public PassInfoMixin<PGOInstrumentationGen> {
public:
PGOInstrumentationGen(bool IsCS = false) : IsCS(IsCS) {}
- PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+ PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
private:
// If this is a context sensitive instrumentation.
@@ -66,7 +66,7 @@ class PGOInstrumentationUse : public PassInfoMixin<PGOInstrumentationUse> {
std::string RemappingFilename = "", bool IsCS = false,
IntrusiveRefCntPtr<vfs::FileSystem> FS = nullptr);
- PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+ PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
private:
std::string ProfileFileName;
@@ -82,7 +82,7 @@ class PGOIndirectCallPromotion : public PassInfoMixin<PGOIndirectCallPromotion>
PGOIndirectCallPromotion(bool IsInLTO = false, bool SamplePGO = false)
: InLTO(IsInLTO), SamplePGO(SamplePGO) {}
- PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+ PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
private:
bool InLTO;
@@ -94,7 +94,7 @@ class PGOMemOPSizeOpt : public PassInfoMixin<PGOMemOPSizeOpt> {
public:
PGOMemOPSizeOpt() = default;
- PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
+ PreservedAnalyses run(Function &F, FunctionAnalysisManager &MAM);
};
void setProfMetadata(Module *M, Instruction *TI, ArrayRef<uint64_t> EdgeCounts,
diff --git a/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp b/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
index c350c73aa10aa6..ae32da139bce8d 100644
--- a/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
+++ b/llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
@@ -327,7 +327,7 @@ bool ICallPromotionFunc::processFunction(ProfileSummaryInfo *PSI) {
// A wrapper function that does the actual work.
static bool promoteIndirectCalls(Module &M, ProfileSummaryInfo *PSI, bool InLTO,
- bool SamplePGO, ModuleAnalysisManager &AM) {
+ bool SamplePGO, ModuleAnalysisManager &MAM) {
if (DisableICP)
return false;
InstrProfSymtab Symtab;
@@ -342,7 +342,7 @@ static bool promoteIndirectCalls(Module &M, ProfileSummaryInfo *PSI, bool InLTO,
continue;
auto &FAM =
- AM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager();
+ MAM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager();
auto &ORE = FAM.getResult<OptimizationRemarkEmitterAnalysis>(F);
ICallPromotionFunc ICallPromotion(F, &M, &Symtab, SamplePGO, ORE);
@@ -361,11 +361,11 @@ static bool promoteIndirectCalls(Module &M, ProfileSummaryInfo *PSI, bool InLTO,
}
PreservedAnalyses PGOIndirectCallPromotion::run(Module &M,
- ModuleAnalysisManager &AM) {
- ProfileSummaryInfo *PSI = &AM.getResult<ProfileSummaryAnalysis>(M);
+ ModuleAnalysisManager &MAM) {
+ ProfileSummaryInfo *PSI = &MAM.getResult<ProfileSummaryAnalysis>(M);
if (!promoteIndirectCalls(M, PSI, InLTO | ICPLTOMode,
- SamplePGO | ICPSamplePGOMode, AM))
+ SamplePGO | ICPSamplePGOMode, MAM))
return PreservedAnalyses::all();
return PreservedAnalyses::none();
diff --git a/llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp b/llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
index 82cabbd28a7aaa..3c8f25d73c623d 100644
--- a/llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
+++ b/llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
@@ -1812,7 +1812,7 @@ static bool InstrumentAllFunctions(
}
PreservedAnalyses
-PGOInstrumentationGenCreateVar::run(Module &M, ModuleAnalysisManager &AM) {
+PGOInstrumentationGenCreateVar::run(Module &M, ModuleAnalysisManager &MAM) {
createProfileFileNameVar(M, CSInstrName);
// The variable in a comdat may be discarded by LTO. Ensure the declaration
// will be retained.
@@ -1824,8 +1824,8 @@ PGOInstrumentationGenCreateVar::run(Module &M, ModuleAnalysisManager &AM) {
}
PreservedAnalyses PGOInstrumentationGen::run(Module &M,
- ModuleAnalysisManager &AM) {
- auto &FAM = AM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager();
+ ModuleAnalysisManager &MAM) {
+ auto &FAM = MAM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager();
auto LookupTLI = [&FAM](Function &F) -> TargetLibraryInfo & {
return FAM.getResult<TargetLibraryAnalysis>(F);
};
@@ -2167,9 +2167,9 @@ PGOInstrumentationUse::PGOInstrumentationUse(
}
PreservedAnalyses PGOInstrumentationUse::run(Module &M,
- ModuleAnalysisManager &AM) {
+ ModuleAnalysisManager &MAM) {
- auto &FAM = AM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager();
+ auto &FAM = MAM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager();
auto LookupTLI = [&FAM](Function &F) -> TargetLibraryInfo & {
return FAM.getResult<TargetLibraryAnalysis>(F);
};
@@ -2180,7 +2180,7 @@ PreservedAnalyses PGOInstrumentationUse::run(Module &M,
return &FAM.getResult<BlockFrequencyAnalysis>(F);
};
- auto *PSI = &AM.getResult<ProfileSummaryAnalysis>(M);
+ auto *PSI = &MAM.getResult<ProfileSummaryAnalysis>(M);
if (!annotateAllFunctions(M, ProfileFileName, ProfileRemappingFileName, *FS,
LookupTLI, LookupBPI, LookupBFI, PSI, IsCS))
More information about the llvm-commits
mailing list