[PATCH] D154943: [ARM] Restructure MOVi32imm expansion to not do pointless instructions

Caslyn Tonelli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 14:39:46 PDT 2023


Caslyn added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1172
 
-  if (isCC)
-    LO16.add(makeImplicit(MI.getOperand(1)));
-  TransferImpOps(MI, LO16, HI16);
+  assert(MI.getNumImplicitOperands() == 0 &&
+         "MOVi32imm expected to have no implicit operands");
----------------
Caslyn wrote:
> Hello - this assert is firing on Fuchsia clang builders, filed https://github.com/llvm/llvm-project/issues/63831 with error output example and reproducer.
Awaiting response from the author, I've submitted a revert for this change https://reviews.llvm.org/D155122.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154943/new/

https://reviews.llvm.org/D154943



More information about the llvm-commits mailing list