[PATCH] D98183: [libLTO] Add support for -save-temps.

[Qiongsi Wu via Phabricator via llvm-commits]

qiongsiwu1 added inline comments.


================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:67
+namespace llvm {
+extern cl::opt<bool> SaveTemps;
+}
----------------
@tejohnson I am going back to this comment https://reviews.llvm.org/D153559#4441538 indicating that it may not be ideal to use the `SaveTemps` option defined in `LTOCodeGenerator.cpp` here for `llvm-lto2`. This particular change was made because we cannot have two `save-temps` coexisting. I thought about renaming one, or both options, but renaming could make both options confusing. Should I call the `llvm-lto2` option `lto2-save-temps`? That is probably not ideal. 

May I get some advice? Is it ok if we reuse the same option? Thanks in advance! 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98183/new/

https://reviews.llvm.org/D98183