[PATCH] D155089: [PowerPC][MC] Set 'future' as default CPU type of AIX

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 13:32:12 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:1223
+    return StringRef("future");
+  return std::nullopt;
+}
----------------
qiucf wrote:
> nemanjai wrote:
> > Why do we restrict this to 64-bit? Just because we do the same for ELF?
> Yes. I'm also not sure is there some specific reason why PPC ELF does this only for 64-bit (since added by D127824, maybe @MaskRay ). After I tested things on 32-bit is okay, the 64-bit constraint will be removed.
Thanks for the suggestion.

I think I restricted D155089 to 64-bit because I didn't test the 32-bit behavior.. I sent https://reviews.llvm.org/D155114 to extend the behavior to 32-bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155089/new/

https://reviews.llvm.org/D155089



More information about the llvm-commits mailing list