[PATCH] D120586: [Attributor] Add AAAddressSpace to deduce address spaces

[Shilei Tian via Phabricator via llvm-commits]

tianshilei1992 added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/address_space_info.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals --prefix-filecheck-ir-name true
+; RUN: opt -aa-pipeline=basic-aa -passes=attributor -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK
+
----------------
arsenm wrote:
> How is this doing anything without a target?
We have many IR tests w/o a target.


================
Comment at: llvm/test/Transforms/Attributor/address_space_info.ll:73
+entry:
+  %0 = load i32, ptr %p, align 4
+  store i32 %0, ptr addrspacecast (ptr addrspace(1) @dst to ptr), align 4
----------------
arsenm wrote:
> Use named values
K, to avoid potential false alarm in the test? I can do it in a following patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120586/new/

https://reviews.llvm.org/D120586