[PATCH] D154638: Emit a .debug_addr section with dsymutil

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham updated this revision to Diff 539654.
rastogishubham marked 13 inline comments as done.
rastogishubham added a comment.

1. Changed assert from UINT16_MAX + UINT8_MAX to UINT32_MAX >> 8

2. Fixed some doxygen comments

3. Removed Index and clear from DebugAddrPool

4. Removed AddrSecSize parameter

5. Added check for -u option in emitDebugAddrSection

5. Removed AddrPool.clear() from cloneAllCompileUnits

6. Removed dwarf version checks where unnecessary

7. Added a test for DW_AT_addr_base and updated dwarf5 tests to check for that attribute as well wherever appropriate


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154638/new/

https://reviews.llvm.org/D154638

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/include/llvm/DWARFLinker/DWARFStreamer.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/test/tools/dsymutil/ARM/dummy-debug-map-amr64.map
  llvm/test/tools/dsymutil/ARM/dwarf5-addr_base.test
  llvm/test/tools/dsymutil/ARM/dwarf5-addrx-0x0-last.test
  llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test
  llvm/test/tools/dsymutil/ARM/dwarf5-macho.test
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base/1.o
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base/2.o
  llvm/test/tools/dsymutil/Inputs/DWARF5-addr_base/3.o
  llvm/test/tools/dsymutil/X86/dwarf5-addrx.test
  llvm/test/tools/dsymutil/X86/dwarf5-dw-op-addrx.test
  llvm/test/tools/dsymutil/X86/dwarf5-rnglists.test
  llvm/test/tools/dsymutil/X86/op-convert-offset.test
  llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-addresses.test
  llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-rnglists.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154638.539654.patch
Type: text/x-patch
Size: 32488 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230712/e578b8d5/attachment.bin>