[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/utils/lit/tests/Inputs/shtest-if-else/test.txt:9
 # RUN: %if feature %{ echo "test-1" %}
-# CHECK-NEXT: {{^.*'RUN}}: at line [[#@LINE-1]]'; echo "test-1"
+#  CHECK-NEXT: {{^.*"RUN}}: at line [[#@LINE-1]]"
+#       CHECK: # command output:
----------------
jdenny wrote:
> awarzynski wrote:
> > jdenny wrote:
> > > awarzynski wrote:
> > > > IIUC, full RUN line would be printed here, right?
> > > Yes.  Previously, this test was looking in the "Script:" section to verify correct expansion of `%if`.  Now that "Script:" is gone, I changed it to just look for correct stdout from the executed command.  Perhaps I should have changed it to look at the printed RUN line (from -vv)?  What do you think?  @asavonic might also want to comment, as he wrote the original test.
> > Hm, so this patch gets rid of "Script", but everything else remains intact, right. The changes in tests suggest that it;s a bit more intrusive, hence my original question.
> I tried to update tests while maintaining their original focus (as well as I understood) and not clutter them with checking of the trace.  I think the changes to shtest-run-at-line.py show the effect of this patch the best.  However, look only at the internal shell checks.  The external shell checks intentionally avoid showing most of the trace given that we have no control over the way they format traces.
> 
> Thanks for this feedback.  I'm going to work on adding an example to the patch summary as well.
> 
> 
> Hm, so this patch gets rid of "Script", but everything else remains intact, right.

Yes, that's right.  It also includes the -vv trace any time -v or -a shows output for a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984