[PATCH] D153499: [RISCV] Add support for custom CSRs for Sifive S76.

garvit gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 08:37:58 PDT 2023


garvitgupta08 marked an inline comment as done.
garvitgupta08 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:360
   const char *Name;
-  const char *AltName;
   const char *DeprecatedName;
----------------
craig.topper wrote:
> Wasn't this field added by a previous version of this patch? Did you upload with the wrong base?
No, In previous version I added AltFeaturesRequired field. AltName field already existed in the SysReg for aliasing but was apparently being used for deprecated names. As mentioned in the commit message that we now have separate class for custom vendor CSRs therefore there is no need for AltName field anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153499/new/

https://reviews.llvm.org/D153499



More information about the llvm-commits mailing list