[PATCH] D155086: [IR] Partially remove pointer element types from intrinsic signatures (NFC)

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:715
 def int_gcroot  : Intrinsic<[],
-                            [llvm_ptrptr_ty, llvm_ptr_ty]>;
+                            [llvm_ptr_ty, llvm_ptr_ty]>;
 def int_gcread  : Intrinsic<[llvm_ptr_ty],
----------------
arsenm wrote:
> these ptrptr ones could use some additional comments explaining what the pointer is
The meaning of the intrinsic arguments is specified in LangRef: https://llvm.org/docs/LangRef.html#llvm-gcroot-intrinsic

I don't really want to repeat LangRef in Intrinsics.td, especially as this does not appear to be the current convention. I don't think the fact that llvm_ptrptr_ty got replaced with llvm_ptr_ty changes anything materially here (i.e., I wouldn't have been able to tell you what this intrinsic does and what the arguments mean before this change either, without consulting LangRef).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155086/new/

https://reviews.llvm.org/D155086