[PATCH] D153499: [RISCV] Add support for custom CSRs for Sifive S76.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1825
+      } else {
+        if(CheckCSRNameConflict())
+          return ParseStatus::Failure;
----------------
space after `if`


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:360
   const char *Name;
-  const char *AltName;
   const char *DeprecatedName;
----------------
Wasn't this field added by a previous version of this patch? Did you upload with the wrong base?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153499/new/

https://reviews.llvm.org/D153499