[PATCH] D155080: [AMDGPU] Corrrectly emit AGPR copies in tryFoldPhiAGPR

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 07:28:39 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFoldOperands.cpp:1793
+    // We can't insert a COPY between PHI nodes so skip them.
+    while (InsertPt != InsertMBB->end() && InsertPt->isPHI())
+      ++InsertPt;
----------------
arsenm wrote:
> You want either getFirstNonPHI, SkipPHIsAndLabels or SkipPHIsLabelsAndDebug
Probably SkipPHIsLabelsAndDebug


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155080/new/

https://reviews.llvm.org/D155080



More information about the llvm-commits mailing list