[PATCH] D154986: [X86] Complete preservation of !pcsections in X86ISelLowering

Marco Elver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 06:07:19 PDT 2023


melver added a comment.

In D154986#4492608 <https://reviews.llvm.org/D154986#4492608>, @dvyukov wrote:

>> However, we're currently still permitting implicit conversion of DebugLoc to MIMetadata, to allow for a gradual transition and let the old code work as-is.
>
> How much of the old code do we still have? Is there any old code in aarch64?

Yes, unfortunately it's still everywhere. It's on my TODO list to remove the implicit conversion DebugLoc -> MIMetadata, so that the type system can help to enforce correct propagation where MachineInstrBuilder is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154986/new/

https://reviews.llvm.org/D154986



More information about the llvm-commits mailing list