[PATCH] D153755: [GlobalISel] Generalize `InstructionSelector` Match Tables

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h:456
   CodeGenCoverage *CoverageInfo = nullptr;
   GISelKnownBits *KnownBits = nullptr;
   MachineFunction *MF = nullptr;
----------------
Hi @Pierre-vh, after merging this patch into a downstream branch I find I have to write this in some of our C++ combines:
```
  struct KnownBits Op0KnownBits = KnownBits->getKnownBits(Reg0);
```
This is a bit ugly because of the name clash between the KnownBits struct and this KnownBits field. I guess this is not a new problem, since you did not change this line, but it is now affecting more code.

Do you think it would make sense to change the name of this field?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153755/new/

https://reviews.llvm.org/D153755