[PATCH] D155051: [AMD] ]Add sanity check that fixes bad shift operation in AMD backend

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 12 02:27:29 PDT 2023


foad added a reviewer: AMDGPU.
foad added a comment.

Seems reasonable.

Stray `]` in first line of commit message, and the target is called "AMDGPU" not "AMD".

An alternative fix would be to avoid the shift altogether, by checking something like `countl_zero(MinMask) + countr_zero(MaxMask) >= 32`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155051/new/

https://reviews.llvm.org/D155051



More information about the llvm-commits mailing list