[PATCH] D154825: [InstCombine][NFC] Rename check run label

Wed Jul 12 01:38:31 PDT 2023

piotr added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/unreachable-code.ll:146
 ; CHECK-SAME: (i32 [[X:%.*]]) {
 ; CHECK-NEXT:    switch i32 -1, label [[DEFAULT:%.*]] [
 ; CHECK-NEXT:    i32 0, label [[CASE0:%.*]]
----------------
nikic wrote:
> piotr wrote:
> > Part of this line contains a substring that could potentially be matched with the check run line "DEFAULT:".
> > 
> Is that intentional FileCheck behavior rather than a bug? It seems pretty odd to me that a check prefix would get matched inside a placeholder declaration of a different check prefix.
Not sure - I was surprised to see this failing too. Maybe `--match-full-lines` would've avoided the failure, although I didn't check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154825/new/

https://reviews.llvm.org/D154825