[llvm] f3059e2 - GlobalOpt: Drop code for handling pointer bitcasts

[Matt Arsenault via llvm-commits]

Author: Matt Arsenault
Date: 2023-07-11T21:05:18-04:00
New Revision: f3059e223dc137ee4111f6e3bb45e7613d6ff7d5

URL: https://github.com/llvm/llvm-project/commit/f3059e223dc137ee4111f6e3bb45e7613d6ff7d5
DIFF: https://github.com/llvm/llvm-project/commit/f3059e223dc137ee4111f6e3bb45e7613d6ff7d5.diff

LOG: GlobalOpt: Drop code for handling pointer bitcasts

I got confused and must have closed the wrong revision for
https://reviews.llvm.org/D149291

Added: 
    

Modified: 
    llvm/lib/Transforms/IPO/GlobalOpt.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
index 5fa53b289ae07e..1ccc523ead8a88 100644
--- a/llvm/lib/Transforms/IPO/GlobalOpt.cpp
+++ b/llvm/lib/Transforms/IPO/GlobalOpt.cpp
@@ -663,8 +663,6 @@ static bool AllUsesOfValueWillTrapIfNull(const Value *V,
       if (II->getCalledOperand() != V) {
         return false;  // Not calling the ptr
       }
-    } else if (const BitCastInst *CI = dyn_cast<BitCastInst>(U)) {
-      if (!AllUsesOfValueWillTrapIfNull(CI, PHIs)) return false;
     } else if (const AddrSpaceCastInst *CI = dyn_cast<AddrSpaceCastInst>(U)) {
       if (!AllUsesOfValueWillTrapIfNull(CI, PHIs))
         return false;
@@ -780,10 +778,9 @@ static bool OptimizeAwayTrappingUsesOfValue(Value *V, Constant *NewV) {
           UI = V->user_begin();
         }
       }
-    } else if (CastInst *CI = dyn_cast<CastInst>(I)) {
-      Changed |= OptimizeAwayTrappingUsesOfValue(CI,
-                                ConstantExpr::getCast(CI->getOpcode(),
-                                                      NewV, CI->getType()));
+    } else if (AddrSpaceCastInst *CI = dyn_cast<AddrSpaceCastInst>(I)) {
+      Changed |= OptimizeAwayTrappingUsesOfValue(
+          CI, ConstantExpr::getAddrSpaceCast(NewV, CI->getType()));
       if (CI->use_empty()) {
         Changed = true;
         CI->eraseFromParent();